Skip to content

London | 25-ITP-May | Houssam Lahlah | Sprint 3 | Alarm Clock #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-May | Houssam Lahlah | Sprint 3 | Alarm Clock #749

wants to merge 10 commits into from

Conversation

HoussamLh
Copy link

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

## Changelist

What I did:

  • Implemented the alarm functionality in alarmclock.js, including countdown logic and triggering audio when the timer reaches zero.
  • Ensured the alarm display updates every second in the format Time Remaining: MM:SS.
  • Connected the "Set Alarm" button to trigger the setAlarm() function.
  • Made functions (setAlarm, playAlarm) testable by exporting them.
  • Ensured compatibility with the test runner by checking typeof document.

## Questions

  • Do you see any potential bugs or improvements in the setAlarm() function structure?

  • Is there a cleaner way to format the MM:SS display?

  • Would you suggest improvements for accessibility or code readability?

HoussamLh added 8 commits July 25, 2025 20:42
@HoussamLh
Add mean calculation test
b06cb19
@HoussamLh
Add test for calculateMedian and calculateMean using salaries array
c9fbbff
@HoussamLh
Add calculateMedian function with tests for even and odd length arrays
95f7fd3
@HoussamLh
I've done the prep of this sprint 2
f02e624
@HoussamLh
access houseNumber property correctly instead of using index
c87010e 
- Changed console.log to use address.houseNumber instead of address[0]
- Ensures correct display of house number in output
@HoussamLh
iterate over object values correctly to log all properties
0b3bd51 
- Replaced invalid for...of loop on object with Object.values()
- Ensures all property values of author are logged without errors
@HoussamLh
correctly log recipe ingredients on separate lines
5c03c87 
- Replaced object string output with ingredients joined by newline
- Ensures each ingredient is printed on its own line as intended
@HoussamLh
I just make my changes by accident in the main branch so I went back …
89b9b6a 
…and fix it from the original main branch
@HoussamLh HoussamLh added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 6, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Aug 9, 2025

This PR branch does not contain any modified files related to Alarm Clock app.

These are the modified files in this branch:
image

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Reviewed Volunteer to add when completing a review with trainee action still to take.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HoussamLh @cjyuan